[tor-bugs] #23564 [Core Tor/Tor]: run make check-changes in CI
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Sep 21 19:55:28 UTC 2017
#23564: run make check-changes in CI
-----------------------------------+------------------------------------
Reporter: catalyst | Owner: nickm
Type: task | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ci tor-doc tor-releng | Actual Points:
Parent ID: #23562 | Points:
Reviewer: | Sponsor:
-----------------------------------+------------------------------------
Changes (by nickm):
* status: needs_revision => needs_review
Comment:
Thanks for the review, catalyst!
The dotfile thing was wrong, but for another reason: It should have
applied inside the `listdir` loop, on the outputs of `listdir`.
I've gone with the non-`walk` approach, since the changes directory does
not contain directories itself.
Fixup commit pushed to `ticket23564`. Better now?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23564#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list