[tor-bugs] #23606 [Core Tor/Tor]: incorrect clock skew sign convention in or_state_load()

[Tor Bug Tracker & Wiki]

#23606: incorrect clock skew sign convention in or_state_load()
------------------------------+--------------------------------
     Reporter:  catalyst      |      Owner:  catalyst
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  clock-skew
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 `or_state_load()` uses an incorrect sign convention for clock skew, which
 causes the log message from `clock_skew_warning()` to be worded
 incorrectly we have warped backward in time since we last wrote our state
 file.  The correct convention is skew is negative if our clock is behind
 (in the past relative to) the reference.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23606>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online