[tor-bugs] #16010 [Applications/Tor Browser]: Get a working content process sandbox for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#16010: Get a working content process sandbox for Tor Browser on Windows
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-security,    |  Actual Points:
  GeorgKoppen201709, TorBrowserTeam201709R       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Replying to [comment:58 gk]:
 > Replying to [comment:57 cypherpunks]:
 > > Replying to [comment:54 gk]:
 > > > `bug_16010_v4` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_16010_v4) has the `tor-browser` patches for review.
 https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_16010_v4&id=03833cf4c2a833f6e5420e92368ac2dae1b99c70
 has the additional code changes I needed to apply.
 > > This makes NPAPI and GMP to fail silently. Gaining a sandbox for
 plugins seems to be worth fixing the problem with underscores.
 >
 > Actually not NPAPI which would not be much of a problem.
 Some mozillians may think NPAPI was removed, and Flash is working through
 some magic. But that's not the case, and sandbox for it is really needed.
 > So, currently this would only affect GMPs but that's a thing we don't
 support out-of-the-box either. We don't want to have DRM GMPs and the
 OpenH264 one is not useful as we are disabling WebRTC.
 WebRTC is needed too (but without holes).
 > That said Mozilla wants to get away from `SANDBOX_EXPORTS` as well, so
 this seems not a bad direction to move in and allows us to use our scarce
 resources somewhere else.
 Do they want to rename all their processes to firefox.exe? (Previous
 attempt failed.)
 > If anybody wants to investigate the underscores issue, please do. I'd
 like to know what's up with that one.
 It seemed Jacek liked such issues :) If so, ni him again.
 But, doesn't it work without underscores with patching
 https://dxr.mozilla.org/mozilla-
 esr52/source/security/sandbox/chromium/sandbox/win/src/interception.h#238?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16010#comment:59>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online