[tor-bugs] #23602 [Core Tor/Tor]: Fix compilation on macOS

[Tor Bug Tracker & Wiki]

#23602: Fix compilation on macOS
--------------------------+------------------------------------
 Reporter:  hellais       |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 I think we need a different fix here.  Look at how we're calling
 TOR_SEARCH_LIBRARY: there are two problems.

 The first problem is that we are detecting OpenSSL by looking for
 RAND_add().  That was once okay, but now that we require OpenSSL 1.0.1, we
 should look for a function that was introduced in OpenSSL 1.0.1.  We
 should probably make sure that it's something that libressl also has, if
 possible.

 (We could probably get away with looking for a function that was
 introduced in 1.0.0, since we're trying to avoid 0.9.8 in particular.)

 The second problem is that our search path doesn't include /usr/local/opt/
 and /usr/local/opt/openssl/.  But we could fix that just by adding them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23602#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online