[tor-bugs] #23080 [Core Tor/Tor]: connection_ext_or_handle_cmd_useraddr and proposal 196 disagree on the format of ExtORPort USERADDR

[Tor Bug Tracker & Wiki]

#23080: connection_ext_or_handle_cmd_useraddr and proposal 196 disagree on the
format of ExtORPort USERADDR
-------------------------------------------------+-------------------------
 Reporter:  dcf                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-spec, pt-spec, needs-spec-       |  Actual Points:
  change, spec                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dcf):

 Replying to [comment:5 nickm]:
 > 17d433247bdfb4 is the torspec patch.

 [https://gitweb.torproject.org/user/nickm/torspec.git/commit/?id=17d433247bdfb4
 17d433247bdfb4] seems fine.

 Replying to [comment:6 nickm]:
 > I have a diagnostic patch for review in `bug23080`. I suggest we take
 that one in 0.3.2, and then reject portless UserAddr commands in 0.3.3 or
 0.3.4.

 Branch
 [https://gitweb.torproject.org/nickm/tor.git/commit/?h=bug23080&id=c4e8548c59c1eb423fe6a39f2712dbc1eff3951a
 bug23080] also looks fine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23080#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online