[tor-bugs] #23589 [Core Tor/Tor]: Stop assuming that every extend_info contains an IPv4 address in get_lspecs_from_extend_info()

[Tor Bug Tracker & Wiki]

#23589: Stop assuming that every extend_info contains an IPv4 address in
get_lspecs_from_extend_info()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 This is safe, because all client extend infos are IPv4.

 Even if they are not, if addr is an IPv6 address, the IPv4 address ends up
 being 0.0.0.0. And it gets rejected in hs_get_extend_info_from_lspecs() by
 extend_info_addr_is_allowed().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23589#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online