[tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

[Tor Bug Tracker & Wiki]

#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core     |    Version:
  Tor/Tor                |
     Severity:  Normal   |   Keywords:  prop224, tor-hs, single-onion, ipv6
Actual Points:           |  Parent ID:  #23493
       Points:  1        |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 Currently, the address choice logic is:
 * if we have an IPv6 address and can reach the ls IPv6 address, and prefer
 IPv6, use it
 * if we have an IPv4 address and can reach the ls IPv4 address, use it

 But it needs to be:
 * if we have both addresses and can reach both, then use whatever we
 prefer
 * if we have one address and can reach it, use it

 This doesn't matter until clients put IPv6 addresses in the link
 specifier.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online