[tor-bugs] #19566 [Core Tor/Tor]: SR: Use BUG() instead of tor_assert() when we can

[Tor Bug Tracker & Wiki]

#19566: SR: Use BUG() instead of tor_assert() when we can
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  tor-sr, dirauth, easy, disaster-     |  Actual Points:
  waiting-to-happen                              |
Parent ID:                                       |         Points:  0.2
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by neel):

 I have made an updated patch under the file
 bug_shared_random_patch_r2.patch​.

 The changes I have made this file is to use the correct use of the BUG()
 function.

 I switched tor_assert() to BUG() in shared_random.c and
 shared_random_state.c in functions that seem related to SR and who's
 return values are void.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19566#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online