[tor-bugs] #23583 [Core Tor/Tor]: ext/timeouts/timeout-bitops.c:234: bad shift

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Sep 19 18:09:10 UTC 2017


#23583: ext/timeouts/timeout-bitops.c:234: bad shift
---------------------------------------+-----------------------------------
 Reporter:  dcb314@…                   |          Owner:  nickm
     Type:  defect                     |         Status:  merge_ready
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.2.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  030-backport 029-backport  |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me.  I think I slightly prefer `x = (uint64_t)1 << i` but
 not strongly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23583#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list