[tor-bugs] #23566 [Core Tor/Tor]: options/validate__transproxy fails on FreeBSD (thanks to the new scheduler)

[Tor Bug Tracker & Wiki]

#23566: options/validate__transproxy fails on FreeBSD (thanks to the new scheduler)
--------------------------+------------------------------------
 Reporter:  pastly        |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sched     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by pastly):

 * keywords:  tor-sched regression => tor-sched


Comment:

 In the spirit of
 >     - removing the sched options caused some tests to pass/fail in new
 ways
 >      so I assumed current behavior is correct and made them pass again

 I present the following. I strongly suspect that the other blocks
 (`OpenBSD` and `__NetBSD__`) need the same fix but I have no way of
 testing.

 {{{
 diff --git a/src/test/test_options.c b/src/test/test_options.c
 index 94a5a034d..72bfb673c 100644
 --- a/src/test/test_options.c
 +++ b/src/test/test_options.c
 @@ -1132,9 +1132,8 @@ test_options_validate__transproxy(void *ignored)
                                  "TransPort 127.0.0.1:123\n");
    ret = options_validate(tdata->old_opt, tdata->opt, tdata->def_opt, 0,
 &msg);
    tt_int_op(ret, OP_EQ, -1);
 -  if (msg) {
 -    TT_DIE(("Expected NULL but got '%s'", msg));
 -  }
 +  tt_str_op(msg, OP_EQ, "ConnLimit must be greater than 0, but was set to
 0");
 +  tor_free(msg);
  #elif defined(OpenBSD)
    tdata = get_options_test_data("TransProxyType pf-divert\n"
                                  "TransPort 127.0.0.1:123\n");
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23566#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online