[tor-bugs] #23552 [Core Tor/Tor]: We don't need to log our scheduler type so often

[Tor Bug Tracker & Wiki]

#23552: We don't need to log our scheduler type so often
------------------------------+--------------------------------
     Reporter:  pastly        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-sched
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 This is silly.

 {{{
 Sep 16 20:54:07.473 [notice] Tor 0.3.2.0-alpha-dev (git-4519b7b469635686)
 running on Linux with Libevent 2.1.8-stable, OpenSSL 1.0.2l, Zlib 1.2.11,
 Liblzma 5.2.3, and Libzstd N/A.
 Sep 16 20:54:07.473 [notice] Tor can't help you if you use it wrong! Learn
 how to be safe at https://www.torproject.org/download/download#warning
 Sep 16 20:54:07.473 [notice] This version is not a stable Tor release.
 Expect more bugs than usual.
 Sep 16 20:54:07.473 [notice] Read configuration file
 "/home/matt/src/tor/torrc".
 Sep 16 20:54:07.475 [warn] Path for DataDirectory (data) is relative and
 will resolve to /home/matt/src/tor/data. Is this what you wanted?
 Sep 16 20:54:07.475 [warn] Path for HiddenServiceDir (data/hs1) is
 relative and will resolve to /home/matt/src/tor/data/hs1. Is this what you
 wanted?
 Sep 16 20:54:07.475 [warn] ControlPort is open, but no authentication
 method has been configured.  This means that any program on your computer
 can reconfigure your Tor.  That's bad!  You should upgrade your Tor
 controller as soon as possible.
 Sep 16 20:54:07.476 [notice] Scheduler type KIST has been enabled.
 Sep 16 20:54:07.476 [notice] Opening Socks listener on 127.0.0.1:23456
 Sep 16 20:54:07.476 [notice] Opening Control listener on 127.0.0.1:12345
 Sep 16 20:54:07.476 [warn] Your log may contain sensitive information -
 you disabled SafeLogging. Don't log unless it serves an important reason.
 Overwrite the log afterwards.
 Sep 16 20:54:07.477 [notice] Scheduler type KIST has been enabled.
 Sep 16 20:54:07.680 [notice] Bootstrapped 0%: Starting
 Sep 16 20:54:07.833 [notice] Scheduler type KIST has been enabled.
 Sep 16 20:54:08.009 [notice] Starting with guard context "default"
 Sep 16 20:54:08.014 [notice] Bootstrapped 80%: Connecting to the Tor
 network
 Sep 16 20:54:08.757 [notice] Bootstrapped 85%: Finishing handshake with
 first hop
 Sep 16 20:54:11.319 [notice] Bootstrapped 90%: Establishing a Tor circuit
 Sep 16 20:54:13.575 [notice] Tor has successfully opened a circuit. Looks
 like client functionality is working.
 Sep 16 20:54:13.575 [notice] Bootstrapped 100%: Done
 Sep 16 20:54:15.049 [notice] Scheduler type KIST has been enabled.
 Sep 16 22:23:16.435 [notice] Scheduler type KIST has been enabled.
 Sep 17 00:18:14.736 [notice] Scheduler type KIST has been enabled.
 Sep 17 01:32:13.524 [notice] Scheduler type KIST has been enabled.
 Sep 17 02:54:08.478 [notice] Heartbeat: Tor's uptime is 5:59 hours, with
 15 circuits open. I've sent 1.70 MB and received 3.21 MB.
 Sep 17 03:20:14.427 [notice] Scheduler type KIST has been enabled.
 Sep 17 05:00:11.271 [notice] Scheduler type KIST has been enabled.
 Sep 17 06:46:11.481 [notice] Scheduler type KIST has been enabled.
 Sep 17 08:06:14.916 [notice] Scheduler type KIST has been enabled.
 Sep 17 08:54:08.480 [notice] Heartbeat: Tor's uptime is 11:59 hours, with
 15 circuits open. I've sent 2.90 MB and received 6.01 MB.
 Sep 17 09:18:12.910 [notice] Scheduler type KIST has been enabled.
 Sep 17 11:15:13.930 [notice] Scheduler type KIST has been enabled.
 Sep 17 12:21:16.363 [notice] Scheduler type KIST has been enabled.
 }}}

 I think we just want to log once on startup, then log only if it changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23552>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online