[tor-bugs] #23539 [Core Tor/Tor]: We've defined "don't use kist" as a negative interval, so don't check for -1

[Tor Bug Tracker & Wiki]

#23539: We've defined "don't use kist" as a negative interval, so don't check for
-1
------------------------------+--------------------------------
     Reporter:  pastly        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-sched, easy
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Of course `== -1` doesn't make sense when KISTSchedRunInterval is a
 unsigned as it currently is (#23538)

 {{{
 @@ -288,9 +288,9 @@ select_scheduler(void)
      case SCHEDULER_KIST:
        if (!scheduler_can_use_kist()) {
  #ifdef HAVE_KIST_SUPPORT
 -        if (get_options()->KISTSchedRunInterval == -1) {
 +        if (get_options()->KISTSchedRunInterval < 0) {
            log_info(LD_SCHED, "Scheduler type KIST can not be used. It is
 "
 -                             "disabled because KISTSchedRunInterval=-1");
 +                             "disabled because KISTSchedRunInterval is <
 0");
          } else {
            log_notice(LD_SCHED, "Scheduler type KIST has been disabled by
 "
                                 "the consensus.");
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23539>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online