[tor-bugs] #23532 [Core Tor/Tor]: NETINFO clock skew detection doesn't work on clients

[Tor Bug Tracker & Wiki]

#23532: NETINFO clock skew detection doesn't work on clients
----------------------------------+------------------------------------
 Reporter:  catalyst              |          Owner:  catalyst
     Type:  defect                |         Status:  needs_review
 Priority:  Medium                |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  bootstrap clock-skew  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by catalyst):

 Maybe the correct test is
 {{{
   (labs(apparent_skew) > NETINFO_NOTICE_SKEW &&
    (chan->conn->handshake_state->started_here ||
     router_get_by_id_digest(chan->conn->identity_digest))
 }}}
 ?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23532#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online