[tor-bugs] #23532 [Core Tor/Tor]: NETINFO clock skew detection doesn't work on clients

[Tor Bug Tracker & Wiki]

#23532: NETINFO clock skew detection doesn't work on clients
------------------------------+----------------------------------
     Reporter:  catalyst      |      Owner:  catalyst
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  bootstrap clock-skew
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+----------------------------------
 The NETINFO clock skew detection code in
 `channel_tls_process_netinfo_cell()` doesn't work for clients because of
 an apparently unnecessary call to `router_get_by_id_digest()`, which will
 generally return `NULL` on clients (which generally download only
 microdescriptors therefore won't populate the routerlist).  This `NULL`
 return prevented the clock skew reporting code from running.  Thanks to
 arma for pointing this out on IRC.  Fixing this would help bootstrap fail
 more quickly in some clock skew situations.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23532>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online