[tor-bugs] #23499 [Core Tor/Tor]: dir server responses should include a Date: header even when not responding 200

[Tor Bug Tracker & Wiki]

#23499: dir server responses should include a Date: header even when not responding
200
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  clock-skew    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.2.x-final


Comment:

 dcd0aea85e9315c53a6b70a4a2b62ec65d539896 seems unnecessary.  we weren't
 logging reason_phrase, but instead were logging `reason_phrase ?
 reason_phrase : "OK"`. Doesn't seem like a terrible problem though.  I'm
 going to turn that conditional into IF_BUG_ONCE.

 Also I think we should renamed write_http_status_line(), since it doesn't
 actually write a line any more.

 I've done both of these in `bug23499` in my repository, based on top of
 yours.  I think this can go in 0.3.2 if you like.  What do  you think of
 the changes?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23499#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online