[tor-bugs] #22805 [Core Tor/Tor]: Remove or_circuit_t.is_first_hop, because it's not accurate any more

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Sep 14 10:02:17 UTC 2017

#22805: Remove or_circuit_t.is_first_hop, because it's not accurate any more
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  technical-debt, security-review,     |  Actual Points:  .3
  review-group-23                                |
Parent ID:                                       |         Points:  1
 Reviewer:  asn                                  |        Sponsor:

Comment (by asn):

 Hello. I'm not very experienced with this channel stuff, so I might be
 wrong but here are my review comments:

 - In comment:1, teor said `we don't want to flag CREATE_FAST users as
 clients any more.`. However, I see that in `command_process_create_cell()`
 we unconditionally call `channel_mark_client(chan);` if we receive a
 `CREATE_FAST` cell. It also contains a comment to that effect, which might
 be outdated given what teor said above. Does it also need a
 `connection_or_digest_is_known_relay(chan->identity_digest)` like the call
 above it? Or perhaps it's ok as is?

 - The comment in `circuit_expire_old_circuits_serverside()` is now
 outdated since it still mentions `create_fast` as an identifier.

 - The branch contains `aa83959ce5` on top which seems to be related to the
 merged #21585. It seemed unrelated to this ticket so I didn't review it.
 Let me know if I should take a look please.

 FWIW, running `test-full` succeeds with the branch.

 Marking this as needs_revision just for the minor comment fix above.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22805#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list