[tor-bugs] #22871 [Obfuscation/BridgeDB]: Implement backend for moat

[Tor Bug Tracker & Wiki]

#22871: Implement backend for moat
----------------------------------------+----------------------
 Reporter:  isis                        |          Owner:  isis
     Type:  enhancement                 |         Status:  new
 Priority:  High                        |      Milestone:
Component:  Obfuscation/BridgeDB        |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  SponsorM, bridgedb-captcha  |  Actual Points:
Parent ID:                              |         Points:  3
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------

Comment (by mcs):

 Replying to [comment:2 isis]:
 > A first draft spec of the API is
 [https://github.com/isislovecruft/bridgedb/tree/fix/22871#accessing-the-
 moat-interface here].  Please review!  I'm finishing up the implementation
 of #15967 and then I'll get starting on implementing this spec.

 This looks pretty good. Kathy isn't here right now, but I will ask her to
 take a look later. I have just a couple of comments:
 1. I am not a fan of the verbose `type` strings, e.g., `moat client
 supported transports`. Maybe this is a JSON-API style thing, but I would
 rather use shorter, easier to compare strings such as `'type': 'client-
 transports'`.

 2. (you asked about this on IRC) The error response seems okay, although
 if there are distinct reasons for failure that would be helpful for end-
 users to know, please add enumerated error codes that Tor Launcher can use
 to pull out a localized string. The way things are now, Tor Launcher will
 probably not use the `title` or `details` field in the UI; maybe just log
 them (because we don't want to show English text to people who speak other
 languages).

 p.s. I like the 419 status string :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22871#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online