[tor-bugs] #12716 [Obfuscation/meek]: Make meek-client-torbrowser take the firefox command as a parameter

[Tor Bug Tracker & Wiki]

#12716: Make meek-client-torbrowser take the firefox command as a parameter
------------------------------+--------------------------------
 Reporter:  dcf               |          Owner:  dcf
     Type:  defect            |         Status:  needs_revision
 Priority:  Low               |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+--------------------------------
Changes (by infinity0):

 * cc: infinity0 (added)


Comment:

 The Tor Browser team is in the long run looking to upstream everything to
 Firefox so it's in everyone's interests to make this not Tor Browser
 specific.

 I definitely don't agree that "meek-client-torbrowser is unlikely now ever
 to work for ordinary Firefox". There have been
 [[https://gitweb.torproject.org/pluggable-transports/meek.git/log/meek-
 client-torbrowser/meek-client-torbrowser.go|minimal changes]] since my
 last proposed patch in 2016-06.

 If my suggestion of a dynamic cross-platform program is still not
 acceptable for some reason, another approach is to build separate programs
 using the same code. Start by renaming the files like this:

 {{{
 m-c-torbrowser/linux.go                     -> m-c-firefox/torbrowser-
 linux.go
 m-c-torbrowser/mac.go                       -> m-c-firefox/torbrowser-
 mac.go
 m-c-torbrowser/meek-client-torbrowser.go    -> m-c-firefox/meek-client-
 firefox.go
    (split tb-specific parts into a wrapper) -> m-c-firefox/meek-client-
 torbrowser.go
 m-c-torbrowser/windows.go                   -> m-c-firefox/torbrowser-
 windows.go
 }}}

 then go from there. However, someone else can write this patch, I don't
 have time for this these days.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online