[tor-bugs] #20168 [Core Tor/Tor]: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Sep 12 14:16:56 UTC 2017

#20168: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif
 Reporter:  dgoulet                       |          Owner:  cjb
     Type:  enhancement                   |         Status:  needs_revision
 Priority:  Very Low                      |      Milestone:  Tor:
                                          |  0.3.2.x-final
Component:  Core Tor/Tor                  |        Version:
 Severity:  Trivial                       |     Resolution:
 Keywords:  easy, lorax, review-group-23  |  Actual Points:  .1
Parent ID:                                |         Points:
 Reviewer:                                |        Sponsor:

Comment (by nickm):

 We can do `/* ... */`, and I tried that at first, but it will make a lot
 more lines that are longer than 80 columns and need to get truncated.
 Still want it?

 I think the issue you're reporting with statefile.h is not about outer vs
 inner, but about the rule that we don't annotate endifs that are within 4
 lines of their ifs.  (See `LINE_OBVIOUSNESS_LIMIT` in the script.)

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20168#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list