[tor-bugs] #23466 [Core Tor/Tor]: hs: v3 client descriptor cache entry should be indexed by blinded key

[Tor Bug Tracker & Wiki]

#23466: hs: v3 client descriptor cache entry should be indexed by blinded key
-----------------------------------------+---------------------------------
 Reporter:  dgoulet                      |          Owner:  (none)
     Type:  defect                       |         Status:  needs_revision
 Priority:  High                         |      Milestone:  Tor:
                                         |  0.3.2.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-hs, tor-client, prop224  |  Actual Points:
Parent ID:                               |         Points:
 Reviewer:  dgoulet                      |        Sponsor:
-----------------------------------------+---------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:  asn => dgoulet


Comment:

 Ok, I was able to map your a,b,c notation with my 1,2,3 notation so good
 :)

 I agree with your (a) approach or (1).

 Yeah, I had some doubts about the feasibility of using the blinded key
 client side but it should work out well with a good expiry time.

 As for (b), great.

 * We might want to remove this because we have a `BUG()` now just before:

 {{{
        log_info(LD_REND, "We already have fresher descriptor. Ignoring.");
 }}}

 * Why remove "now" from the parameter list? `hs_cache_clean_as_client()`
 is called from the main loop with a now() already set. Furthermore, I'm
 curious how the test can work with a consensus time in 1985 and the clean
 cache function using `approx_time()` ? The cache entry will simply get
 removed all the time no?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23466#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online