[tor-bugs] #23479 [Core Tor/Tor]: Bug: ../src/or/config.c:785: get_options_mutable: Non-fatal assertion ! in_option_validation failed

[Tor Bug Tracker & Wiki]

#23479: Bug: ../src/or/config.c:785: get_options_mutable: Non-fatal assertion !
in_option_validation failed
------------------------------------+------------------------------------
 Reporter:  gk                      |          Owner:  (none)
     Type:  defect                  |         Status:  new
 Priority:  High                    |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor            |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  tor-config, tor-client  |  Actual Points:
Parent ID:                          |         Points:
 Reviewer:                          |        Sponsor:
------------------------------------+------------------------------------
Changes (by dgoulet):

 * keywords:   => tor-config, tor-client
 * priority:  Medium => High


Comment:

 Oooook #22281 was merged yesterday but then I just realized this that in
 `options_trial_assign()`:

 {{{
   in_option_validation = 1;

   if (options_validate(get_options_mutable(), trial_options,
                        global_default_options, 1, msg) < 0) {
 }}}

 Basically, setting `in_option_validation` to 1 and then right after
 calling `get_options_mutable()` which triggers the assert...

 Two things. 1) Why don't I get this while using master since yesterday...
 and 2) How come our unit tests didn't catch that... ?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23479#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online