[tor-bugs] #22281 [Core Tor/Tor]: Prevent pattern of bugs caused by calling get_options() within options_validate() etc

[Tor Bug Tracker & Wiki]

#22281: Prevent pattern of bugs caused by calling get_options() within
options_validate() etc
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:                   |         Points:
 Reviewer:  dgoulet          |        Sponsor:
-----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Not sure here...

 It seems that the "option validation" is broader then just calling
 `options_validate()`. Like in `options_trial_assign()`, it seems it is
 from validation up to when we set the option in `set_options()`.

 Shouldn't we follow that as well in `options_init_from_string()` that is
 reset `in_option_validation` after the set options. Or fix the above and
 not include `set_options()`? (I'm saying that because `set_options()`
 calls `options_act()` for which the very first thing it does is to call
 `get_mutable_options()` meaning triggering the assert...?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22281#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online