[tor-bugs] #22215 [Core Tor/Tor]: networkstatus_nickname_is_unnamed() can get ripped out

[Tor Bug Tracker & Wiki]

#22215: networkstatus_nickname_is_unnamed() can get ripped out
-----------------------------+------------------------------------
 Reporter:  arma             |          Owner:  (none)
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-23  |  Actual Points:
Parent ID:  #12898           |         Points:
 Reviewer:  nickm            |        Sponsor:
-----------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 The first two parts of this commit are fine, but the changes in dirvote.c
 need to become conditional, and only happen when a new consensus method is
 provided.

 The problem is that the consensus-generation code in dirvote.c needs to be
 run in exactly the same way on all the authorities for all inputs, or else
 they can produce different outputs, which will make them not agree on the
 consensus.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22215#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online