[tor-bugs] #22281 [Core Tor/Tor]: Prevent pattern of bugs caused by calling get_options() within options_validate() etc

[Tor Bug Tracker & Wiki]

#22281: Prevent pattern of bugs caused by calling get_options() within
options_validate() etc
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:                   |         Points:
 Reviewer:  dgoulet          |        Sponsor:
-----------------------------+------------------------------------

Comment (by nickm):

 I think you're right.  I added a fixup commit for this. Better now?

 (I also ran it through the chutney tests to see if they would complain.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22281#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online