[tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Sep 7 10:17:07 UTC 2017
#23215: set annotation from descriptor during sync-runs
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: defect | Status: closed
Priority: Medium | Milestone: CollecTor 1.3.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution: fixed
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Changes (by karsten):
* status: merge_ready => closed
* resolution: => fixed
Comment:
Tweaked the change log a bit, rebased to master, and pushed.
Regarding variable names, I think we shouldn't use abbreviations other
than commonly known ones like IP or HTTP etc. It's true that there are
quite a few `sb` and `is` and so on in the code. We might replace them
with more meaningful names.
Closing. Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23215#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list