[tor-bugs] #21585 [Core Tor/Tor]: Check code that uses consensus membership to find clients

[Tor Bug Tracker & Wiki]

#21585: Check code that uses consensus membership to find clients
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  triaged-out-20170308, tor-relay is-  |  Actual Points:
  client refactor client-detection technical-    |
  debt                                           |
Parent ID:  #22805                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 The patch in the parent ticket kills off the is_first_hop flag.

 I have looked over all the uses of node_get_by_id() to make sure we aren't
 using it for client-testing without an appropriate wrapper
 [connection_or_digest_is_known_relay].  I also looked at the routerstatus-
 lookup functions.

 There is a problem with the router_get_by_id_digest() function -- it is
 used too much, when some other test would be more correct.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21585#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online