[tor-bugs] #22934 [Core Tor/Tor]: PADDING cells can't be sent immediately after a VERSIONS cell

[Tor Bug Tracker & Wiki]

#22934: PADDING cells can't be sent immediately after a VERSIONS cell
---------------------------------+------------------------------------
 Reporter:  teor                 |          Owner:  nickm
     Type:  defect               |         Status:  accepted
 Priority:  Medium               |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor         |        Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal               |     Resolution:
 Keywords:  tor-spec, tor-relay  |  Actual Points:
Parent ID:  #18856               |         Points:  0.5
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------

Comment (by nickm):

 >I think we should fix this by changing the channel state immediately
 after the VERSIONS cell is read, rather than after all the cells in the
 buffer are processed.

 FWIW, this makes me a touch nervous -- did you mean, changing the
 negotiated version?  I worry that if we change the "state" field itself,
 we'll accidentally make other parts of the code think that the channel has
 finished authenticating.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22934#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online