[tor-bugs] #20168 [Core Tor/Tor]: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Sep 6 15:33:05 UTC 2017

#20168: Clarify our #if{n}def by commenting what they are at the #elif/#else/#endif
 Reporter:  dgoulet       |          Owner:  cjb
     Type:  enhancement   |         Status:  needs_review
 Priority:  Very Low      |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Trivial       |     Resolution:
 Keywords:  easy, lorax   |  Actual Points:  .1
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
Changes (by nickm):

 * status:  needs_revision => needs_review
 * reviewer:  nickm =>
 * actualpoints:   => .1


 Hm.  So, let's try again. I don't think we can require a specific vim
 plugin if we're going to have this be a regular part of our toolchain.  So
 how about we try it in Python?  I've put a script in an `annotate_ifdefs`
 branch in my public repository that I think does just about everything we
 want.  I've put a sample of its output in `annotate_ifdefs_sample_output`,
 but we should re-run it immediately on merge if we decide to take it.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20168#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list