[tor-bugs] #23346 [Core Tor/Tor]: prop224: HSdir set changed detection fails sometimes

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Sep 4 16:30:39 UTC 2017


#23346: prop224: HSdir set changed detection fails sometimes
-----------------------------+------------------------------------
 Reporter:  asn              |          Owner:  (none)
     Type:  defect           |         Status:  closed
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:  fixed
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  dgoulet          |        Sponsor:  SponsorR-can
-----------------------------+------------------------------------
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Hm. This code changes from an `O(n log n)` algorithm (sort and compare) to
 an `O(n^2^)` algorithm (iterate over list, searching second list for each
 element).  I guess that's okay, because these lists are small?

 If that's so, this looks okay to me.  Merging.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23346#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list