[tor-bugs] #23762 [Core Tor/Tor]: hs-v3: Client request with missing dirinfo will always timeout

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Oct 31 13:25:13 UTC 2017


#23762: hs-v3: Client request with missing dirinfo will always timeout
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224, tor-client,         |  Actual Points:
  review-group-24                                |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:  asn => dgoulet


Comment:

 Changes lgtm;

 Tests were failing and leaking. See branch with a fixup commit for that:
 `bug23762_032_02`

 Agree on the testing but it ain't easy to test this in unit test which
 requires _many_ thing to interact. We kind of have to bet on our
 integration test and user base for testing :S. However, that code path is
 hit in unit test for sure at least.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23762#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list