[tor-bugs] #23848 [Core Tor/Tor]: Replace all exit() calls with return code style

[Tor Bug Tracker & Wiki]

#23848: Replace all exit() calls with return code style
-------------------------------------------------+-------------------------
 Reporter:  hellais                              |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-mobile, 0.3.5-deferrable,        |  Actual Points:
  review-group-24                                |
Parent ID:  #23684                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by nickm):

 Thanks for the review!  I've commented on those issues and merged.

 > `c82cc8acb5aa43b3d96490d927dcc622f2c825e3` looks good, but maybe we
 should remove this code if we notice that it is never used during this
 release cycle?

 I've added an XXXX comment about that, but I'm not 100% sure we should: if
 there is some weird bug that makes us not actually exit, I bet it will be
 hard to find.  In that case, it would be good to make sure that Tor didn't
 just keep running once it had been asked to stop.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23848#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online