[tor-bugs] #23573 [Core Tor/Tor]: Do we want to close all connections when tor closes?

[Tor Bug Tracker & Wiki]

#23573: Do we want to close all connections when tor closes?
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  shutdown, privcount, correctness,    |  Actual Points:
  chutney-wants, review-group-24                 |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:5 nickm]:
 > Needs a changes file.

 Ack.

 > I'd rather have a real fix for #23570 than the sleep() call here, if at
 all possible.
 > Maybe we should just fflush() everything?

 The sleep() call isn't a great fix. I think fflush() would be a good idea:
 I'm not sure if it's enough.

 > I think that rather than having main.c call hibernate_go_dormant, we
 should extract the relevant part of hibernate_go_dormant into a new
 function, and have main.c call that.

 Ack.

 > The commit message says `Implements #435`, but I don't think that's
 right?

 It's right for experimental PrivCount :-)
 I'll fix it now I know we want something like this upstreamed.

 Replying to [comment:6 nickm]:
 > > Is the connection_mark_for_close() in hibernate_go_dormant enough
 here? It only marks the connections; it doesn't necessarily close them.
 >
 > Oh! Does this patch assume that #23571 is also merged?

 Yes. Or at least, it doesn't try to duplicate that functionality.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23573#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online