[tor-bugs] #24008 [Core Tor/Tor]: service_intro_point_new() should return NULL when passed a NULL extend_info

[Tor Bug Tracker & Wiki]

#24008: service_intro_point_new() should return NULL when passed a NULL extend_info
------------------------------+---------------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.2.1-alpha
     Severity:  Normal        |   Keywords:  prop224, tor-hs, refactor
Actual Points:                |  Parent ID:
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+---------------------------------------
 We pass a NULL extend_info to service_intro_point_new() in the unit tests,
 and expect a non-NULL return value.

 But buggy code could also pass NULL here, and we should return NULL if
 that happens.

 One way to fix this is to split the function into two, and only call the
 first half in the unit tests.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24008>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online