[tor-bugs] #24002 [Core Tor/Tor]: Check for ed25519 key is inverted in pick_intro_point()

[Tor Bug Tracker & Wiki]

#24002: Check for ed25519 key is inverted in pick_intro_point()
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.2.1-alpha
     Severity:  Normal        |   Keywords:  prop224
Actual Points:                |  Parent ID:
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In pick_intro_point(), we should check that nodes that claim to support
 ed25519 have a key, not the other way around:
 {{{
   /* Let's do a basic sanity check here so that we don't end up
 advertising the
    * ed25519 identity key of relays that don't actually support the link
    * protocol */
   if (!node_supports_ed25519_link_authentication(node)) {
     tor_assert_nonfatal(ed25519_public_key_is_zero(&info->ed_identity));
   }
 }}}

 Also, this check is already done in node_get_ed25519_id() via
 extend_info_for_node() for ri, but not md. So I think we could also fix
 this issue by fixing #24001 instead, and removing the check from
 pick_intro_point().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24002>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online