[tor-bugs] #23981 [Metrics/CollecTor]: Fix NPE and include "bridge-distribution-request" lines in sanitized bridge descriptors

[Tor Bug Tracker & Wiki]

#23981: Fix NPE and include "bridge-distribution-request" lines in sanitized bridge
descriptors
-------------------------------+------------------------------
 Reporter:  karsten            |          Owner:  iwakeh
     Type:  defect             |         Status:  needs_review
 Priority:  High               |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:13 arma]:
 > Replying to [comment:10 karsten]:
 > > Oh, and we still need to make a final decision what to do with those
 new lines. Okay to keep them unchanged?
 >
 > I hope we choose "yes, ok to keep them unchanged". That way external
 researchers will be able to tie together usage patterns, and blocking
 patterns, to the distribution method that the bridge asked for.

 That's the current plan, yes.

 > (I am still sad that we don't record (and publish) what distribution
 mechanism bridgedb picked for a bridge. Most bridges probably won't set
 this line on their own, so seeing this line won't be a substitute for
 learning what bridgedb decided to do.)

 Good point. I'll put "Resume gathering bridge distribution statistics from
 BridgeDB" on the roadmap we're about to finish soon, though it will be on
 the long-term list for Q4/2018 or later. But at least we'll remember when
 we make the next roadmap or run out of other goals earlier than we thought
 (hahaha).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23981#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online