[tor-bugs] #23975 [Core Tor/Tor]: Make node_get_*_orport() check addresses in the right order

[Tor Bug Tracker & Wiki]

#23975: Make node_get_*_orport() check addresses in the right order
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.2.8.1-alpha
     Severity:  Normal        |   Keywords:  ipv6, regression
Actual Points:                |  Parent ID:  #20916
       Points:  1             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 node_get_pref_ipv6_orport() and node_get_prim_orport() check addresses in
 the following order:
 * routerinfo / descriptor (modified by rewrite_bridge_address_for_node())
 * routerstatus / consensus
 * microdesc

 Clients, bridge clients, and relays usually get the correct address from
 node_get_pref_ipv6_orport() and node_get_prim_orport(), whether they are
 using microdescriptors or not.

 But there are a few cases when this breaks:
 * bridge clients should only check routerinfo for configured bridges
 * all clients and relays that use microdescs should never check full
 descriptors (and vice versa, except for the bridge case)
 * all clients and relays that use full descriptors should ignore the IPv6
 address in the descriptor
 * all clients and relays that use microdescriptors should ignore the IPv6
 address in the microdescriptor, when using a consensus method that puts
 IPv6 addresses in the microdesc consensus, otherwise they should use the
 microdescriptor

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23975>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online