[tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Thanks for this patch, we're almost there!

 Code Logic:

 This check is incorrect, it should use `node_has_ipv6_orport()`:

 {{{
 if (node_ipv6_or_preferred(node)) {
 }}}

 `node_ipv6_or_preferred()` returns true if this client prefers IPv6 for
 this node. But link specifiers are sent to a remote client, which applies
 its own IPv6 preferences to the addresses. So we need to send the IPv6
 address whenever it is available.

 The code assumes that addr_len and the length of in6_addr are the same. I
 think it's probably ok for us to assume that.

 Code Structure:

 For consistency with `node_has_curve25519_onion_key()`, can you please
 change the name of `node_get_curve25519_key()` to
 `node_get_curve25519_onion_key()`?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23577#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online