[tor-bugs] #23954 [Core Tor/Tor]: Race condition in LOG_PROTOCOL_WARN

Mon Oct 23 16:41:31 UTC 2017

#23954: Race condition in LOG_PROTOCOL_WARN
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 LOG_PROTOCOL_WARN currently calls get_options().  After #23952 is merged,
 it will call get_protocol_warning_severity_level().  The trouble is, both
 of these functions access a global variable without acquiring a lock...
 and LOG_PROTOCOL_WARN can be invoked from outside the main thread.

 Let's fix this once #23952 and #23953 are merged.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23954>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online