[tor-bugs] #23848 [Core Tor/Tor]: Replace all exit() calls with return code style

[Tor Bug Tracker & Wiki]

#23848: Replace all exit() calls with return code style
-----------------------------------------+---------------------------------
 Reporter:  hellais                      |          Owner:  nickm
     Type:  enhancement                  |         Status:  needs_review
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.3.3.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-mobile,0.3.5-deferrable  |  Actual Points:
Parent ID:  #23684                       |         Points:
 Reviewer:                               |        Sponsor:
-----------------------------------------+---------------------------------
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 See branch `exit_carefully` in my public repository.

 This branch handles all but a few cases that I had marked as `XXXX bad
 exit`.  I'm hoping to add tests, and also to open tickets for the
 remaining cases.

 (The remaining cases are all ones where IMO safe recovery is potentially
 difficult.  I also added some "XXXX" comments for cases where
 options_act() is behaving poorly, but IMO those are separate bugs.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23848#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online