[tor-bugs] #23848 [Core Tor/Tor]: Replace all exit() calls with return code style

[Tor Bug Tracker & Wiki]

#23848: Replace all exit() calls with return code style
-----------------------------------------+---------------------------------
 Reporter:  hellais                      |          Owner:  (none)
     Type:  enhancement                  |         Status:  new
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.3.3.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-mobile,0.3.5-deferrable  |  Actual Points:
Parent ID:  #23684                       |         Points:
 Reviewer:                               |        Sponsor:
-----------------------------------------+---------------------------------

Comment (by nickm):

 I've gone over the code.  I found 19 unproblematic uses of exit(), and 24
 ones that we should fix.  I annotated the good ones with "exit ok" and the
 bad ones with "XXXX bad exit" in
 `35746a9ee75608e7b2393e4519adca602bf2615f`.

 There are probably a few bad exits in particular that will account for
 most of the undesirable exit() calls: the ones in hibernate.c; a few of
 the ones in main.c; and one or two in config.c.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23848#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online