[tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-----------------------------+----------------------------------
 Reporter:  isis             |          Owner:  (none)
     Type:  defect           |         Status:  new
 Priority:  Medium           |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:                   |         Points:  1
 Reviewer:                   |        Sponsor:  SponsorZ
-----------------------------+----------------------------------
Changes (by manish.earth):

 * cc: manishearth@… (added)


Comment:

 The recommendation is to commit them for binaries and not libraries, but
 the actual recommendation is closer to "commit them for things which won't
 be used as dependencies of other rust crates". Which is true for binaries,
 but also for static libraries that you link to from C. So for the
 staticlib you compile you probably want to check in the lockfile.

 (You'll need to check in a lockfile if you intend to cargo vendor crates
 anyway)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22906#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online