[tor-bugs] #23844 [Metrics/ExoneraTor]: Fix NullPointerException thrown by providing invalid parameters

[Tor Bug Tracker & Wiki]

#23844: Fix NullPointerException thrown by providing invalid parameters
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  defect              |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
Changes (by iwakeh):

 * status:  new => needs_review


Comment:

 The problem got introduced in
 [https://gitweb.torproject.org/exonerator.git/tree/src/main/java/org/torproject/exonerator/ExoneraTorServlet.java?id=0d79dbd211e7e7d06e1435cf7d78f1abc3bf4365#n184
 this commit], where the NPE happens when writing
 [https://gitweb.torproject.org/exonerator.git/tree/src/main/java/org/torproject/exonerator/ExoneraTorServlet.java?id=0d79dbd211e7e7d06e1435cf7d78f1abc3bf4365#n228
 the permanent link].

 Please review this
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-23488
 patch], which avoids providing the permanent link when there was invalid
 user input.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23844#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online