[tor-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Oct 11 19:05:24 UTC 2017
#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status: needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Critical | Resolution:
Keywords: noscript | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------------
Comment (by cypherpunks):
Replying to [comment:26 ma1]:
Hi, Giorgio.
Unfortunately, not all issues with the Security Slider were resolved. The
last one is that `NoScript preferences backup on the WebExtension side`
doesn't happen right after updating NoScript settings by the Torbutton.
This has weird effects, e.g. videos play automatically on Low, but under
the rectangle of blocked video, and NoScript icon and menu show that the
video was blocked (left from the previously selected Medium level).
> A lot of scary stuff spit by the console is unrelated to NoScript
specifically (may apply to any hybrid / restatless extension) and/or
cannot be fixed "from the inside" of the add-on: case in point, from the
browser being unable to delete temporary files
{{{
17:21:54.970 1507742514900 addons.xpi ERROR Failed to remove
file C:\Tor
Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\trash\{73a6fe31
-595d-460b-a920-fcc0f8843232}.xpi: [Exception... "Component returned
failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"
nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame
:: resource://gre/modules/addons/XPIProvider.jsm :: recursiveRemove ::
line 2005" data: no] Stack trace:
recursiveRemove()@resource://gre/modules/addons/XPIProvider.jsm:2005 <
recursiveRemove()@resource://gre/modules/addons/XPIProvider.jsm:2020 <
.installAddon()@resource://gre/modules/addons/XPIProvider.jsm:8600 <
startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5951 <
TaskImpl_run()@resource://gre/modules/Task.jsm:319 <
Handler.prototype.process()@resource://gre/modules/Promise.jsm ->
resource://gre/modules/Promise-backend.js:932 <
this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm ->
resource://gre/modules/Promise-backend.js:813 <
this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm
-> resource://gre/modules/Promise-backend.js:747 1 Log.jsm:753
App_append resource://gre/modules/Log.jsm:753:9
Logger.prototype.log resource://gre/modules/Log.jsm:389:7
Logger.prototype.error resource://gre/modules/Log.jsm:397:5
recursiveRemove
resource://gre/modules/addons/XPIProvider.jsm:2010:7
forEach self-hosted:251:13
recursiveRemove
resource://gre/modules/addons/XPIProvider.jsm:2020:3
.installAddon resource://gre/modules/addons/XPIProvider.jsm:8600:9
startInstall/<
resource://gre/modules/addons/XPIProvider.jsm:5951:20
next self-hosted:1120:9
TaskImpl_run resource://gre/modules/Task.jsm:319:42
bound TaskImpl_run self-hosted:957:17
Handler.prototype.process resource://gre/modules/Promise-
backend.js:932:23
this.PromiseWalker.walkerLoop resource://gre/modules/Promise-
backend.js:813:7
bound self-hosted:913:17
bound bound self-hosted:913:17
this.PromiseWalker.scheduleWalkerLoop/< resource://gre/modules
/Promise-backend.js:747:11
1507742514900 addons.xpi WARN Failed to remove trash directory
when installing {73a6fe31-595d-460b-a920-fcc0f8843232}: [Exception...
"Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)
[nsIFile.remove]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"
location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm ::
recursiveRemove :: line 2005" data: no] Stack trace:
recursiveRemove()@resource://gre/modules/addons/XPIProvider.jsm:2005 <
recursiveRemove()@resource://gre/modules/addons/XPIProvider.jsm:2020 <
.installAddon()@resource://gre/modules/addons/XPIProvider.jsm:8600 <
startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5951 <
TaskImpl_run()@resource://gre/modules/Task.jsm:319 <
Handler.prototype.process()@resource://gre/modules/Promise.jsm ->
resource://gre/modules/Promise-backend.js:932 <
this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm ->
resource://gre/modules/Promise-backend.js:813 <
this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm
-> resource://gre/modules/Promise-backend.js:747
}}}
This is an `ERROR` exactly and should be fixed.
> or to register chrome packages at the right time.
Addons should wait until manifest is registered by Firefox. This is
critical.
> >
> >
> > {{{
> > No chrome package registered for
chrome://noscript/locale/about.properties
> > 08:26:39.787 No matching message handler for the given recipient. 1
MessageChannel.jsm:621
> > _handleMessage/</< resource://gre/modules/MessageChannel.jsm:621:11
> > }}}
>
> ... or this, which might happen whenever any WebExtension is uninstalled
/ disabled if there were pending messages.
{{{
1507747660900 addons.xpi DEBUG Calling bootstrap method startup
on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc5
1507747661000 DeferredSave.extensions.json DEBUG Starting timer
1507747661000 addons.xpi DEBUG removeTemporaryFile:
https://addons.mozilla.org/firefox/downloads/latest-
beta/noscript/addon-722-latest.xpi?src=search removing temp file
C:\Users\X\AppData\Local\Temp\tmp-2sv.xpi
No matching message handler for the given recipient.
MessageChannel.jsm:621
}}}
So, this happens in exact place during addon's startup.
> > and comment:22.
>
> This should be fixed ('''in most cases''', at least) by
[https://noscript.net/getit#devel rc5] (about to become a release) and was
cosmetic anyway.
Now we have
{{{
1507740751000 addons.webextension.<unknown> WARN Loading extension
'null': Reading manifest: Error processing permissions.1: Unknown
permission "privacy"
1507740751000 addons.webextension.<unknown> WARN Loading extension
'null': Reading manifest: Error processing permissions.4: Unknown
permission "unlimitedStorage"
1507740751800 addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}
WARN Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}':
Reading manifest: Error processing permissions.1: Unknown permission
"privacy"
1507740751800 addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}
WARN Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}':
Reading manifest: Error processing permissions.4: Unknown permission
"unlimitedStorage"
}}}
and
{{{
noscript-tbb not found!
[10-11 17:02:22] Torbutton INFO: New window
}}}
which is an exclamation about the obvious thing :)
As for comment:22, the links point to the tickets with annoying issues
with functionality, not only cosmetic ones.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list