[tor-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

[Tor Bug Tracker & Wiki]

#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by cypherpunks):

 It seems Giorgio doesn't talk with anonymous :)
 But, nevertheless, let's summarize the results of rc4:

 Clean install:
 {{{
 No chrome package registered for chrome://noscript/skin/icon32.png
 1507707555800 addons.xpi WARN Failed to remove temporary file
 C:\Users\X\AppData\Local\Temp\tmp-04t.xpi for addon
 https://addons.mozilla.org/firefox/downloads/latest-
 beta/noscript/addon-722-latest.xpi?src=ss: [Exception... "Component
 returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)
 [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"
 location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm ::
 removeTemporaryFile :: line 5598"  data: no] Stack trace:
 removeTemporaryFile()@resource://gre/modules/addons/XPIProvider.jsm:5598 <
 startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:6027 <
 Handler.prototype.process()@resource://gre/modules/Promise.jsm ->
 resource://gre/modules/Promise-backend.js:932 <
 this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm ->
 resource://gre/modules/Promise-backend.js:813 <
 this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm
 -> resource://gre/modules/Promise-backend.js:747
 [10-11 07:39:15] Torbutton NOTE: Failed to update NoScript status for
 security setings: TypeError: win.noscriptOverlay is undefined
 1507707556000 addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}
 WARN Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}': Reading
 manifest: Error processing permissions.1: Unknown permission "privacy"
 }}}
 The first error (two similar, actually) leads to NoScript's two icons in
 Customize menu don't show. TBB doesn't use them, though.
 gk: the second error is `tbb-disk-leak`.

 Restartless update:
 {{{
 No chrome package registered for chrome://noscript/locale/about.properties
 08:26:39.787 No matching message handler for the given recipient. 1
 MessageChannel.jsm:621
         _handleMessage/</<
 resource://gre/modules/MessageChannel.jsm:621:11
 }}}

 and comment:22.

 Security Slider survived \o/

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online