[tor-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Oct 10 21:07:47 UTC 2017


#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by gk):

 Replying to [comment:21 ma1]:
 > Replying to [comment:20 gk]:
 >
 >
 >
 > > >
 > > 1) Extract a clean Tor Browser 7.5a5
 > > 2) Copy NoScript 5.1.2rc2 over the NoScript we ship
 > > 3) Start the browser, the icon is on the left side
 > > 4) Check for NoScript updates and 5.1.2r3 gets installed and the icon
 jumps to the right
 >
 > I suppose you're doing this, rather than updating directly from a non-
 restartless version (like the ones you currently ship) to check whether
 updating restartless to restartless makes the icon jump nevertheless.
 However, since rc2 interferes with the previous icon placement in a way
 rc3 doesn't, whether the effect is visible or not, I'd rather try to
 update from rc3 to rc4 (about to be released) to tell if the bug needs
 more work or not.

 Sounds good and, yes, that what was my intention behind the testing.

 >
 > > We have a bunch of
 > > {{{
 > > [10-09 15:36:27] Torbutton NOTE: Failed to update NoScript status for
 security setings: TypeError: win.noscriptOverlay is undefined
 > > }}}
 > > errors in the console as we call its `_syncUINOw()` once a NoScript
 pref gets changed (and that happens with the update apparently). But that
 does not seems to be a candidate for causing this issue to me. Hm
 >
 > I don't think it's a real problem, console noise aside, but if you want
 it to be fixed anyway you must do it on your side: on initialization
 NoScript might cause preference observers to be called at a moment when
 noscriptOverlay does not exist yet: this means you must check for
 win.noscriptOverlay existence before referencing it.

 Sure. I was just mentioning it as the other thing I saw on the browser
 console.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list