[tor-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

[Tor Bug Tracker & Wiki]

#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by gk):

 Replying to [comment:19 ma1]:
 > Replying to [comment:18 gk]:
 >
 > > This looks better, thanks. But I still get:
 > > {{{
 > > TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
 > > TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
 > > TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
 > > TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
 > > No matching message handler for the given recipient.
 MessageChannel.jsm:621
 > > }}}
 > > in the browser console.
 > >
 >
 > If you're installing over a previous restartless version (5.1.x) that's
 normal, noisy but no side effect, and nothing we can't do about it because
 those messages are from the previous instance. It shouldn't happen for new
 installations and/or upgrading / disabling+enabling over 5.1.2rc3 and
 above.

 Okay.

 > And the icon is still jumping to the right. Any idea why this one in
 particular is happening?
 >
 > Again, if the icon has already "jumped" on the right there's nothing to
 do about it, because you cannot tell whether it happened because of a
 previous restartless version or becuase the user customized the position
 manually.
 >
 > However it should not change the icon position from where it's found
 initially (e.g. if you install on a fresh Tor Browser it should stay on
 the left).

 But that's what I did:

 1) Extract a clean Tor Browser 7.5a5
 2) Copy NoScript 5.1.2rc2 over the NoScript we ship
 3) Start the browser, the icon is on the left side
 4) Check for NoScript updates and 5.1.2r3 gets installed and the icon
 jumps to the right

 We have a bunch of
 {{{
 [10-09 15:36:27] Torbutton NOTE: Failed to update NoScript status for
 security setings: TypeError: win.noscriptOverlay is undefined
 }}}
 errors in the console as we call its `_syncUINOw()` once a NoScript pref
 gets changed (and that happens with the update apparently). But that does
 not seems to be a candidate for causing this issue to me. Hm.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online