[tor-bugs] #23762 [Core Tor/Tor]: hs-v3: Client request with missing dirinfo will always timeout

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 4 20:26:41 UTC 2017


#23762: hs-v3: Client request with missing dirinfo will always timeout
-----------------------------------------+---------------------------------
 Reporter:  dgoulet                      |          Owner:  (none)
     Type:  defect                       |         Status:  needs_review
 Priority:  High                         |      Milestone:  Tor:
                                         |  0.3.2.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-hs, prop224, tor-client  |  Actual Points:
Parent ID:                               |         Points:
 Reviewer:  asn                          |        Sponsor:
-----------------------------------------+---------------------------------
Changes (by dgoulet):

 * status:  new => needs_review
 * reviewer:   => asn


Comment:

 After discussing with asn, I went with a third option which was is to let
 the connection state in "renddesc wait" and add a callback to the HS
 client subsystem if the directory information changes.

 This turns out to be tricky but here is an attempt. I believe it is not
 perfect but it gives us a baseline to discuss:

 See branch: `bug23762_032_01`.

 First commit is a refactor splitting our refetch function into validation
 and fetching. Nothing to do with the fix per-se, we can easily just remove
 it but originally it was part of the fix and I kept it because I think it
 is nicer.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23762#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list