[tor-bugs] #23759 [Core Tor/Tor]: Refactor common code out of setup_introduce1_data and intro point functions

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 4 05:20:57 UTC 2017


#23759: Refactor common code out of setup_introduce1_data and intro point functions
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  prop224, tor-hs, single-onion,
     Severity:  Normal   |  ipv6, refactor
Actual Points:           |  Parent ID:  #23493
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 During #23577, we discovered that there's a lot of code in
 setup_introduce1_data() that's duplicated in service_intro_point_new() and
 hs_desc_lspec_to_trunnel().

 And in #23577, we want to copy more of it.

 So we should clean that up at some point, but it's complicated, because
 the intro point functions use hs_desc_link_specifier_t.

 Or we could add comments in the duplicate code to tell us to check the
 other functions when any one of them changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23759>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list