[tor-bugs] #23500 [Core Tor/Tor]: check-spaces.pl should check spaces after a comma when in functions.

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 4 04:27:42 UTC 2017


#23500: check-spaces.pl should check spaces after a comma when in functions.
--------------------------+------------------------------------
 Reporter:  ewong         |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Trivial       |     Resolution:
 Keywords:  code-style    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Thanks for your work on this.

 There's one last thing you need to fix:
 1. Put all the changes to check-spaces.pl in one commit. In the latest
 branch, the script is changed in the first and third commits.

 Once that's done, I'll send this to the release manager and see if they
 are happy with the manual mass change.
 We can use diff's ignore whitespace option to check that only whitespace
 was modified.
 But we'll still need to manually confirm that none of the whitespace was
 significant.

 Then, after final review, we need to:
 2. Merge this patch to master, and fix any spacing issues it identifies in
 new code

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23500#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list