[tor-bugs] #23500 [Core Tor/Tor]: check-spaces.pl should check spaces after a comma when in functions.

[Tor Bug Tracker & Wiki]

#23500: check-spaces.pl should check spaces after a comma when in functions.
--------------------------+------------------------------------
 Reporter:  ewong         |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Trivial       |     Resolution:
 Keywords:  code-style    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by ewong):

 This is my attempt at a 'mass change'
 https://github.com/ewongbb/tor/tree/chkspace_f

 I had attempted to do a mass change with a script but the amount of time
 trying to
 figure out the code which should be changed compared to those that
 shouldn't
 would've been better used on reading and looking for the general instances
 that apply.  So I apologize as this 'mass change' was pretty much a manual
 process.


 Do note I took a few liberties at the following:

 1) changed indent where I think would be proper (though I probably missed
 quite
    a few)
 2) reformatted some lines to make it less 'Wide'

 As such some caveats:
 a) haven't touched C code(and even then, I was just a beginner)
 b) I'm not familiar with the tor code and didn't want to do too much
 damage,
    particularly with some whitespace which I think should be there but
 didn't
    change.  i.e.   if conditions with all the conditions whitespaceless..
          if (i=0;i<10;i++) {... }   [no, this isn't from the code.. just
 an example]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23500#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online